Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop: Ignore Rails/Delegate #6131

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Rubocop: Ignore Rails/Delegate #6131

merged 1 commit into from
Feb 18, 2025

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Feb 18, 2025

This rule makes code shorter, but much less understandable.

@mamhoff
Rubocop: Ignore Rails/Delegate
90ce190 
This rule makes code shorter, but much less understandable.
@mamhoff mamhoff requested a review from a team as a code owner February 18, 2025 10:56
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Feb 18, 2025
tvdeyen
tvdeyen approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tvdeyen tvdeyen enabled auto-merge February 18, 2025 10:59
@tvdeyen tvdeyen mentioned this pull request Feb 18, 2025
Closed
4 tasks
@tvdeyen tvdeyen merged commit 69d4d57 into solidusio:main Feb 18, 2025
18 of 21 checks passed
@tvdeyen tvdeyen added backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 labels Feb 19, 2025
This was referenced Feb 19, 2025
Merged
Merged
Merged
Merged
@github-actions GitHub Actions
Copy link

💔 Some backports could not be created

Status Branch Result
❌ v4.1 An unhandled error occurred. Please see the logs for details
✅ v4.2
❌ v4.3 An unhandled error occurred. Please see the logs for details
✅ v4.4

Manual backport

To create the backport manually run:

backport --pr 6131

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions GitHub Actions
Copy link

💔 Some backports could not be created

Status Branch Result
✅ v4.1
❌ v4.2 An unhandled error occurred. Please see the logs for details
✅ v4.3
✅ v4.4

Manual backport

To create the backport manually run:

backport --pr 6131

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions GitHub Actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ v4.1
✅ v4.2
✅ v4.3
✅ v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions GitHub Actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ v4.1
✅ v4.2
✅ v4.3
✅ v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 changelog:repository Changes to the repository not within any gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamhoff @tvdeyen