[v4.5] Respect Spree.user_class' table name in metadata migration #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
A Spree.user_class might have a different table_name than spree_users. In order to support this we need to ask the class for it's table_name. (cherry picked from commit 1bcdfe4)
github-actions
bot
added
changelog:solidus_core
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.5 #6158 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 835 835
Lines 18149 18149
=======================================
Hits 16121 16121
Misses 2028 2028 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.5:Questions ?
Please refer to the Backport tool documentation