initial TLSRoute support #10601
Merged
initial TLSRoute support #10601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kick-ci |
danehans
requested changes
Feb 14, 2025
| @@ -128,6 +128,8 @@ func (r *gatewayQueries) GetRouteChain( | |||
| case *gwv1a2.TCPRoute: | |||
| backends = r.resolveRouteBackends(ctx, typedRoute) | |||
| // TODO (danehans): Should TCPRoute delegation support be added in the future? | |||
| case *gwv1a2.TLSRoute: | |||
There was a problem hiding this comment.
@puertomontt can you create an issue to rename projects/gateway2/query/httproute.go to projects/gateway2/query/route.go and link to this PR?
projects/gateway2/translator/listener/gateway_listener_translator.go
Outdated
Show resolved
Hide resolved
projects/gateway2/translator/listener/gateway_listener_translator.go
Outdated
Show resolved
Hide resolved
projects/gateway2/translator/listener/gateway_listener_translator.go
Outdated
Show resolved
Hide resolved
| @@ -248,6 +248,16 @@ func (p *plugin) computeTcpFilterChain( | |||
| }, nil | |||
| } | |||
|
|
|||
| // needed to handle passthrough | |||
| if sslConfig.GetSslSecrets() == nil && len(sslConfig.GetSniDomains()) != 0 { | |||
There was a problem hiding this comment.
nit: Call len(sslConfig.GetSniDomains() once and store the results in a var. Then you can use the var here and in L256.
...ernetes/e2e/features/services/tlsroute/testdata/cross-ns-no-refgrant-gateway-and-client.yaml
Outdated
Show resolved
Hide resolved
nfuden
reviewed
Feb 17, 2025
|
Issues linked to changelog: |
nfuden
reviewed
Feb 21, 2025
danehans
approved these changes
Feb 22, 2025
nfuden
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
looks good.
The build bot failure seems to be a known issue docker/buildx#1170
|
/skip-ci temporary qemu issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds initial support for TLSRoutes. TLSRoutes are similar to TCPRoutes, but the distinction between them is that TLSRoutes allows routing decisions by SNI. See docs.
This PR adds support for TLS Passthrough on a TLS listener using a TLSRoute.
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
This PR doesn't add TLS support for TCPRoutes (kgateway-dev#10621)
Checklist: