This repository has been archived by the owner on May 17, 2022. It is now read-only.
Remove jquery #17
Draft
Remove jquery #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prefix xmlns to be usable with querySelector
|
What a coincident. I am the maintainer of svgdom :D. But you probably wanna look at jsdom. It mirrors the browser environment pretty closely. svgdom is mostly useful if you need a bounding box or matrix calculations for your svgs. Well, I guess for this usecase it would work fine as well |
|
It's not really a coincident. The PR is based on your PR and we already discussed the use of other libraries like svgdom in the comments. |
|
I guess it's too long ago to remember 😂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native might be broken! Since we removed jQuery, we accidentally introduced a dependency on the browser environment. I'm open for solutions.
A solution might be xmldom or svgdom.