Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add role data source #8

Merged
merged 3 commits into from
Apr 8, 2024
Merged

feat: add role data source #8

merged 3 commits into from
Apr 8, 2024

Conversation

iverberk
Copy link
Contributor

No description provided.

@iverberk iverberk force-pushed the role-data-source branch 2 times, most recently from 0087412 to 5a96659 Compare March 14, 2024 20:38
@iverberk iverberk marked this pull request as ready for review March 14, 2024 20:39
@iverberk iverberk requested a review from madpah as a code owner March 14, 2024 20:39
@iverberk
Copy link
Contributor Author

@madpah any chance you could review and let me know if this is ok? I'm planning on sending more resources shortly.

@iverberk iverberk force-pushed the role-data-source branch 2 times, most recently from 537db93 to 9027581 Compare April 6, 2024 21:07
@madpah
Copy link
Collaborator

madpah commented Apr 8, 2024

@iverberk - can you please look at the test failures?

@madpah madpah added the enhancement New feature or request label Apr 8, 2024
@iverberk
Copy link
Contributor Author

iverberk commented Apr 8, 2024 •
edited
Loading

Yep, I'll take a look and add docs as well 👍

@iverberk
Copy link
Contributor Author

iverberk commented Apr 8, 2024

@madpah the tests seem to failing on two things:

  1. Doc generation. I'll fix that.
  2. Unavailable provider configuration environment variables. I assumed that those env variables would be set in the CI/CD configuration, otherwise I don't know what to point them to. Can you clarify which IQ server URL needs to be used and how it should be set? Locally I just use a docker container.

@madpah
Copy link
Collaborator

madpah commented Apr 8, 2024

@iverberk - thanks - I'll look at 2.

@iverberk
Copy link
Contributor Author

iverberk commented Apr 8, 2024

Ok, I think the docs are fixed.

@madpah madpah mentioned this pull request Apr 8, 2024
Open
27 tasks
@madpah madpah merged commit a75d10a into sonatype-nexus-community:main Apr 8, 2024
2 of 7 checks passed
@madpah madpah mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madpah madpah madpah approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iverberk @madpah