-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Add HLD for Private Link Redirect Map #664
Open
jimmyzhai
wants to merge
2
commits into
sonic-net:main
Choose a base branch
from
jimmyzhai:pl_redirect_map_hld
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+259
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Commenter does not have sufficient privileges for PR 664 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 664 in repo sonic-net/DASH |
jimmyzhai
force-pushed
the
pl_redirect_map_hld
branch
from
January 28, 2025 04:58
7ef1f8e
to
deb4fc3
Compare
/azp run |
Commenter does not have sufficient privileges for PR 664 in repo sonic-net/DASH |
jimmyzhai
force-pushed
the
pl_redirect_map_hld
branch
from
January 28, 2025 05:10
deb4fc3
to
4b2a85d
Compare
/azp run |
Commenter does not have sufficient privileges for PR 664 in repo sonic-net/DASH |
jimmyzhai
force-pushed
the
pl_redirect_map_hld
branch
from
January 28, 2025 05:13
4b2a85d
to
ba72c71
Compare
/azp run |
Commenter does not have sufficient privileges for PR 664 in repo sonic-net/DASH |
jimmyzhai
force-pushed
the
pl_redirect_map_hld
branch
from
January 28, 2025 05:17
ba72c71
to
0fb019e
Compare
/azp run |
Commenter does not have sufficient privileges for PR 664 in repo sonic-net/DASH |
r12f
reviewed
Jan 29, 2025
|
||
#### 5.1.1 Private Link | ||
1. **VNI Lookup**: First, we will look up the VNI to determine the packet direction. In this case, we consider all the packets from on-premises network as outbound direction from the floating NIC perspective. | ||
```json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be better to describe the things in the form of SAI API in DASH, and leaving the SONiC dash tables into the SONiC-DASH HLD as DB schema and etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.