Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for DockerService.List #199

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

hdwhdw
Copy link
Contributor

@hdwhdw hdwhdw commented Jan 7, 2025

Implementation for DockerService.List with unit tests.

ADO: 30171023
Issue: SONiC 1880

This is the DBUS backend for the GNOI Containerz.ListContainer RPC. It lists all containers with its status, images, labels etc.

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FengPan-Frank
Copy link
Contributor

could you pls add more description or ADO link for more context?

@hdwhdw
Copy link
Contributor Author

hdwhdw commented Jan 14, 2025

@FengPan-Frank Added ADO, Issue and some description. The content is pretty self-explanatory, so description is just to mention why I do this.

@hdwhdw hdwhdw requested a review from FengPan-Frank January 14, 2025 09:21
Copy link
Contributor

@FengPan-Frank FengPan-Frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdwhdw hdwhdw merged commit 0430ada into sonic-net:master Jan 14, 2025
5 checks passed
@hdwhdw hdwhdw deleted the list branch January 23, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants