Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip warm reboot on isolated topology for test_bgp_session.py #17322

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sdszhang
Copy link
Contributor

@sdszhang sdszhang commented Mar 4, 2025

Description of PR

Summary:
Fixes the following error in test_bgp_session.py:

>           raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E           tests.common.errors.RunAnsibleModuleFail: run module command failed, Ansible Results =>
E           failed = True
E           changed = True
E           rc = 101
E           cmd = ['warm-reboot']
E           start = 2025-02-28 21:50:57.537650
E           end = 2025-02-28 21:51:03.919474
E           delta = 0:00:06.381824
E           msg = non-zero return code
E           invocation = {'module_args': {'_raw_params': 'warm-reboot', '_uses_shell': False, 'warn': False, 'stdin_add_newline': True, 'strip_empty_ends': True, 'argv': None, 'chdir': None, 'executable': None, 'creates': None, 'removes': None, 'stdin': None}}
E           _ansible_no_log = None
E           stdout =
E           stderr =
E           ISSU is not enabled on this HWSKU
E           Warm reboot is not supported

FAILED bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-reboot]
FAILED bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-bgp_docker]
FAILED bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-swss_docker]
FAILED bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-reboot]

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

warm/fast reboot is not supported on t0-isolated or t1-isolated topology.

How did you do it?

skip it on isolated topology
also update the wait time after shutdown bgp neighbor to align with default hold-timer

How did you verify/test it?

Verified on physical testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@sdszhang sdszhang requested a review from StormLiangMS as a code owner March 4, 2025 12:43
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Contributor Author

sdszhang commented Mar 4, 2025

Test result:

bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-bgp_docker] PASSED [ 16%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-swss_docker] PASSED [ 33%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-reboot] SKIPPED [ 50%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-bgp_docker] PASSED [ 66%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-swss_docker] PASSED [ 83%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-reboot] SKIPPED [100%]
------------------------------ live log teardown -------------------------------

@sdszhang
Copy link
Contributor Author

sdszhang commented Mar 4, 2025

@r12f for review

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@Pterosaur Pterosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants