thermalctld: Ignore exception when deleting chassisdb entry fails #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After sonic-mgmt tests, it does a config consistency check and if the config consistency check fails, it runs recover_chassis(). That function simultaneously runs config_reload on the supervisor and all linecards (in parallel). This means that the supervisor networking can be in the process of restarting when thermalctld exits and goes through the cleanup process of deleting entries from chassisdb.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After sonic-mgmt tests, it does a config consistency check and if the config consistency check fails, it runs recover_chassis(). That function simultaneously runs config_reload on the supervisor and all linecards (in parallel). This means that the supervisor networking can be in the process of restarting when thermalctld exits and goes through the cleanup process of deleting entries from chassisdb.
Motivation and Context
This fixes a thermalctld crash when the supervisor and linecards simultaneously do a
config reload(fixes sonic-net/sonic-buildimage#21058). This causes a failure during sonic-mgmt testing.How Has This Been Tested?
This change has been applied in Arista internal test environment and the thermalctl crash was not seen with this change applied.
Additional Information (Optional)