-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MathJax version (3.2.0 -> 3.2.2) #14
base: main
Are you sure you want to change the base?
Conversation
This is normally inserted automatically when you have a To do it by hand, you would need to add import {VERSION} from 'mathjax-full/js/components/version.js';
if (MathJax.loader) {
MathJax.loader.checkVersion('[custom]/xypic.js', VERSION, 'tex-extension');
} to your |
load: ['[custom]/xypic.js'], | ||
paths: {custom: 'https://cdn.jsdelivr.net/gh/sonoisa/[email protected]/build/'} | ||
load: ['[xypic]'], | ||
paths: {xypic: 'https://cdn.jsdelivr.net/gh/sonoisa/[email protected]/build/xypic'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is not necessary to have the .js
in the load
references, you probably do want to include the '.js' here, however, as this is an actual file reference. It probably works without it, but it feels wrong to leave it off here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it looks a bit silly, but with a naked '[xypic]'
, which I agree is the best option, it adds a .js extension no matter what - so you get a reference to xypic.js.js which doesn't load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOPS! Sorry, my bad. I guess the filters that add the .js
and that resolve the [...]
are in the wrong order. I'll look into that. Thanks for letting me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! I should thank you for coming with the perfect build answer, you really made my day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to help.
paths: {custom: '.'} // specify the path where xypic.js is located. | ||
// This example assumes that xypic.js is in the same place as html. | ||
load: ['[xypic]'], | ||
paths: {xypic: './xypic'} // specify the path where xypic.js is located (without .js). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
Updates mathjax-full to 3.2.2 and fixes a rendering error in the test files.
I've tested it and it works the same as before, the only "issue" is that there is the following warning when using MathJax 3.2.1+
No version information available for component xypic.js
which ideally should've gone away by uplifting and building with a newer version of MathJax.
I've been trying to get the version info into the component when packing and have looked through the following issues trying to figure it out.
mathjax/MathJax-src#738
mathjax/MathJax-src#818
A workaround would be to just suppress the version warnings, but I guess it's an easy fix if you know where the version-info should go.