forked from Ada-C11/exquisite-react
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feedback, PR template, and assignment duedate details
- Loading branch information
Showing
3 changed files
with
31 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Exquisite React | ||
Congratulations! You're submitting your assignment. | ||
|
||
## Comprehension Questions | ||
|
||
Feature | Feedback | ||
--- | --- | ||
How did this project differ from in-class examples? | | ||
How was this project similar to in-class examples? | | ||
If you had time to refactor one part of this project, what would you do to make it better? | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Exquisite React | ||
## What We're Looking For | ||
|
||
Feature | Feedback | ||
--- | --- | ||
**General** | | ||
Answered comprehension questions | | ||
Small commits with meaningful commit messages | | ||
**Code Requirements** | | ||
Form submissions from `PlayerSubmissionForm` sent data back up to the `Game` component | | ||
Submissions from the `Game` component propagated to the `FinalPoem` component | | ||
Recent Submission only showed up if there was at least one previous submission | | ||
Best practices were followed: appropriate use of `props` and `state`, `propTypes` were defined, etc | | ||
**Overall** | |