Skip to content

Commit

Permalink
feedback, PR template, and assignment duedate details
Browse files Browse the repository at this point in the history
  • Loading branch information
tildeee committed Dec 11, 2018
1 parent d6fa5fd commit 6994093
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Exquisite React
Congratulations! You're submitting your assignment.

## Comprehension Questions

Feature | Feedback
--- | ---
How did this project differ from in-class examples? |
How was this project similar to in-class examples? |
If you had time to refactor one part of this project, what would you do to make it better? |
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Exquisite React

## At a Glance
- Individual, [stage 2](https://github.com/Ada-Developers-Academy/pedagogy/blob/master/rule-of-three.md#stage-2) project
- Due before class, **DATE HERE**

## Introduction

> Exquisite Corpse is a collaborative poetry game that traces its roots to the Parisian Surrealist Movement. Exquisite Corpse is played by several people, each of whom writes a word on a sheet of paper, folds the paper to conceal it, and passes it on to the next player for [their] contribution.
Expand Down Expand Up @@ -135,3 +139,6 @@ Refactor your project so `PlayerSubmissionForm` dynamically generates the poetry
`FIELDS` is an array that contains both strings and objects. Iterating over this and using elements in this array should have certain conditions to think about, but it shouldn't feel too tricky.

Feel free to use a different data structure other than what `FIELDS` has if you don't like it, but it's what the deployed version uses.

## What Instructors Are Looking For
Check out the [feedback template](feedback.md) which lists the items instructors will be looking for as they evaluate your project.
14 changes: 14 additions & 0 deletions feedback.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Exquisite React
## What We're Looking For

Feature | Feedback
--- | ---
**General** |
Answered comprehension questions |
Small commits with meaningful commit messages |
**Code Requirements** |
Form submissions from `PlayerSubmissionForm` sent data back up to the `Game` component |
Submissions from the `Game` component propagated to the `FinalPoem` component |
Recent Submission only showed up if there was at least one previous submission |
Best practices were followed: appropriate use of `props` and `state`, `propTypes` were defined, etc |
**Overall** |

0 comments on commit 6994093

Please sign in to comment.