[REFACTOR] Spring boot 2->3 migration 및 JAVA 21 도입 - #347 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kseysh
approved these changes
Sep 24, 2024
| @@ -51,19 +51,20 @@ public class S3Service { | |||
| @Value("${cloud.aws.s3.uri}") | |||
| private String baseURI; | |||
|
|
|||
| private final AmazonS3 amazonS3; | |||
| private AmazonS3 amazonS3; | |||
There was a problem hiding this comment.
Q. AmazonS3가 객체 변수로 들어가야하는 이유가 있을까요?
There was a problem hiding this comment.
P1. final로 들어가 있지 않으면 uploadDeprecated에서 NPE가 발생할 것 같아요
There was a problem hiding this comment.
기존의 S3service를 @PostConstruct구조로 생성되기 전에 빈으로 등록하는과정에서 오류가 발생했었습니다!
따라서 기존의 코드를 유지하되 지정되는 빈을 등록해주게 하기 위해 다음과 같이 구현하게 되었습니다!
Comment on lines
3
to
14
| import jakarta.persistence.Column; | ||
| import jakarta.persistence.Convert; | ||
| import jakarta.persistence.Entity; | ||
| import jakarta.persistence.GeneratedValue; | ||
| import jakarta.persistence.GenerationType; | ||
| import jakarta.persistence.Id; | ||
| import jakarta.validation.constraints.NotNull; | ||
| import lombok.AccessLevel; | ||
| import lombok.AllArgsConstructor; | ||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; |
| @@ -16,7 +16,7 @@ public class FortuneCardRepositoryImpl implements FortuneCardRepository { | |||
| @Override | |||
| public Optional<FortuneCard> findByRelatedUserId(final Long userId) { | |||
|
|
|||
| QFortuneCard fortuneCard = new QFortuneCard("fortuneCard"); | |||
| QFortuneCard fortuneCard = QFortuneCard.fortuneCard; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR Summary
🌴 Works
🌱 Related Issue
closed #347
🌵 PR 참고사항