Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

홈탭 번쩍 캐러셀 및 모임 카드 MO #974

Merged
merged 7 commits into from
Jan 11, 2025
Merged

홈탭 번쩍 캐러셀 및 모임 카드 MO #974

merged 7 commits into from
Jan 11, 2025

Conversation

j-nary
Copy link
Member

@j-nary j-nary commented Dec 31, 2024

🚩 관련 이슈

📋 작업 내용

  • 번쩍 캐러셀 구현
  • 모임카드 Tablet, Mobile 구현

📸 스크린샷

  • 홈탭 반응형

    2025-01-01.3.36.37.mov
  • 홈탭 번쩍 캐러셀 애니메이션

    2025-01-01.3.38.17.mov

@j-nary j-nary self-assigned this Dec 31, 2024
Copy link

height bot commented Dec 31, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

<MobileCard
key={d.id}
id={d.id}
imageURL={d.imageURL[0].url}
Copy link
Contributor

@borimong borimong Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imageURL 이 null / undefined 일 경우 undefined 참조 에러가 날 것 같다는 우려가 있습니다!
imageURL 이 반복되어 쓰이는 것 같아서, 지난 pr 에서 제가 언급드린 그라운드룰에 따라 ?? 연산자 사용해서 converted 값을 하나 선언해주고 사용하면 어떨까요~? ex) const convertedImageURL = d.imageURL ?? [{url: ''}] (디폴트값)
추가로 제가 이번에 추가한 noUncheckedIndexedAccess 타입스크립트 옵션이 제 역할을 잘 한다면, develop 최신화해주신 후 만든 브랜치에선 앞으로 이런 경우에 타입 에러 잘 뜰거에요! :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!! 반영완료했습니다 :)

Copy link
Contributor

@ocahs9 ocahs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 고생하셨습니다 👍

@j-nary j-nary merged commit 09c0d9a into develop Jan 11, 2025
1 check passed
@j-nary j-nary deleted the feat/#973 branch January 11, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

홈탭 번쩍 캐러셀
3 participants