[REFACTOR] 전체 조회에 대한 Filter 요청에 대해 Early Return 적용

sopt-makers · Dec 28, 2024 · 8328cd7 · 8328cd7
1 parent 43a04ec
commit 8328cd7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...ion-api/src/main/java/org/sopt/makers/operation/web/banner/service/BannerServiceImpl.java b/...ion-api/src/main/java/org/sopt/makers/operation/web/banner/service/BannerServiceImpl.java
@@ -110,10 +110,10 @@ public List<BannerSimple> getBanners(FilterCriteria filter, SortCriteria sort) {
     }
 
     private List<Banner> getFilteredBanners(List<Banner> banners, FilterCriteria filter) {
-        val targetStatus = PublishStatus.getByValue(filter.getParameter());
-        if (targetStatus == null) {
+        if (FilterCriteria.ALL.equals(filter)) {
             return banners;
         }
+        val targetStatus = PublishStatus.getByValue(filter.getParameter());
         return banners.stream()
                 .filter(banner -> targetStatus.equals(banner.getPeriod().getPublishStatus(LocalDate.now())))
                 .toList();