Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] 응답 데이터 총 개수 추가 #206

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[ADD] 응답 데이터 총 개수 추가 #206

merged 3 commits into from
Dec 7, 2023

Conversation

thguss
Copy link
Collaborator

@thguss thguss commented Dec 6, 2023

Related Issue 🚀

Work Description ✏️

  • �클라이언트 요청입니다.
  • Pageable 파라미터가 포함된 URI 기준으로, 조건과 일치하는 데이터의 총 개수 데이터를 추가했습니다.
  • totalCount 필드명 통일
  • List 타입 자체로 응답하는 API는 새로운 DTO를 생성하여 한 번 감쌌습니다.
  • 로컬 기준 테스트 진행했습니다.

PR Point 📸

  • 용택 담당이었던 전체 회원 조회도 요청에 포함되는 API 여서 제 나름대로 수정했습니다. 문제가 있다면 알려주세요! 🙇‍♀️

@thguss thguss added sohyeon 소현 작업 add 작업 추가 labels Dec 6, 2023
@thguss thguss requested a review from dragontaek-lee December 6, 2023 02:08
@thguss thguss self-assigned this Dec 6, 2023
Copy link
Member

@dragontaek-lee dragontaek-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경된 부분 문제 없어보입니다~! 더 좋아요!

@thguss thguss added this pull request to the merge queue Dec 7, 2023
Merged via the queue into develop with commit e36725c Dec 7, 2023
1 check passed
@thguss thguss deleted the sohyeon_#203 branch December 7, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add 작업 추가 size/L sohyeon 소현 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] 리스트 데이터 개수 추가
2 participants