Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT/#293] 배너 수정 API 구현 #294

Merged
merged 9 commits into from
Jan 18, 2025
Merged

[FEAT/#293] 배너 수정 API 구현 #294

merged 9 commits into from
Jan 18, 2025

Conversation

sung-silver
Copy link
Contributor

Related Issue 🚀

Work Description ✏️

  • 배너 수정 API를 구현했습니다
  • 모든 필드를 수정 가능하도록 구현했습니다
  • 그러나 수정마다 S3에서 이미지를 삭제하고 다시 생성한다는 점에서 클라이언트와 이미지 변경 여부에 대한 필드 논의를 해보려고합니다

PR Point 📸

  • 클라이언트와의 논의 이후 변경되면 알려드릴게요..!

@sung-silver sung-silver added feat 기능 구현 sungeun labels Dec 23, 2024
@sung-silver sung-silver self-assigned this Dec 23, 2024
@height Height
Copy link

height bot commented Dec 23, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

yummygyudon
yummygyudon approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@yummygyudon yummygyudon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다!! 고생하셨어요!!

사소한 Swagger 관련 오타 외에는 큰 이슈가 없어보입니다!!

operation-api/src/main/java/org/sopt/makers/operation/web/banner/api/BannerApi.java Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 18, 2025
@sung-silver sung-silver merged commit f5fc166 into develop Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yummygyudon yummygyudon yummygyudon approved these changes

@hyunw9 hyunw9 Awaiting requested review from hyunw9

Assignees

@sung-silver sung-silver

Labels
feat 기능 구현 size/L sungeun
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 배너 - 수정
2 participants
@sung-silver @yummygyudon