cmake: linux: sync with upstream plugin template #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing on linux, currently the project has things hard-coded in cmake to install to - usr/dist/obs-multi-rtmp/data/locale for the translation files - usr/dist/obs-multi-rtmp/bin/64bit/obs-multi-rtmp.so for the shared library Yet we want things to go to these two folders instead - usr/share/obs/obs-plugins/obs-multi-rtmp/locale/ - usr/lib64/obs-plugins/obs-multi-rtmp.so Use upstream template code [1] that enables using these vars to decide where things get installed - CMAKE_INSTALL_BINDIR - CMAKE_INSTALL_LIBDIR - CMAKE_INSTALL_DATAROOTDIR [1] https://github.com/obsproject/obs-plugintemplate
AdelKS
force-pushed
the
linux-template-sync
branch
from
7bcde62 to
27dedd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
When installing on linux, currently the project has things hard-coded in cmake to install to
usr/dist/obs-multi-rtmp/data/localefor the translation filesusr/dist/obs-multi-rtmp/bin/64bit/obs-multi-rtmp.sofor the shared libraryYet I want things to go to these two folders instead
usr/share/obs/obs-plugins/obs-multi-rtmp/locale/usr/lib64/obs-plugins/obs-multi-rtmp.soUnfortunately I cannot do anything about it except patching the cmake files: we can sync with the upstream code for the cmake files, and that gives variables we can use to tweak where files go:
CMAKE_INSTALL_BINDIRCMAKE_INSTALL_LIBDIRCMAKE_INSTALL_DATAROOTDIR