Enable editable scenarios #7
Conversation
|
Good point! This is just a feature that I am suggesting. Cuz once people want to edit things, that usually implies they want full control. This is basically making things easier to handle. |
There was a problem hiding this comment.
Some meta-comments:
- Instead of listing the "create your own scenario" on the side bar. Create a button on the above to with text like "editable", once it is selected, all the things become editable and goals become omniscient
- Put scenario in a single row, besides just listing the codename, include a few tokens of the scenario, so people could have a preview of the scenario before choing them
- Allow choose models for each agent, include a special human model, which would require human input. If all models are not humans, then we do normal sotopia simulation.
|
@bugsz thanks for the update, some new feedback |
|
Still in progress.. |
|
A bit strange behavior on my end: |
|
| set_from_env_agent_profile_combo(env_agent_combo=env_agent_combo, reset_msgs=False) | ||
|
|
||
|
|
||
| from sotopia.database import EpisodeLog |
| rewards=rewards, | ||
| rewards_prompt="", | ||
| ) | ||
| from socialstream.rendering_utils import render_messages |
| message_list = [message.replace("**", "") for message in message_list] | ||
| return "\n".join(message_list) | ||
|
|
||
| # print(epilog.render_for_humans()) |
| return agent_profile_to_secret_info(profile, display_name=display_name) | ||
|
|
||
|
|
||
| def _agent_profile_to_friendabove_self( |
| return agent_to_render | ||
|
|
||
|
|
||
| def render_messages( |
There was a problem hiding this comment.
shouldn't this be in the rendering folder?
socialstream/chat/chat_omniscient.py
Outdated
There was a problem hiding this comment.
qq, isn't chat_omniscient kind of replicating a lot of features in chat.py? Can we combine them?
|
Also, I notice that we use the callback functions. Any chance you can update the readme to introduce/explain that concept? |
|
@XuhuiZhou I think ready to merge! |
The same as #6, but in a new branch name.
The first commit addresses #3, and the following commits address #4
Btw whether the scenario is editable does not relate to the omniscient? (i.e. we can still only show partial information while making the scenario editable?)