Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Merge release into main #214

Merged
merged 31 commits into from
Oct 4, 2024
Merged

[Automated] Merge release into main #214

merged 31 commits into from
Oct 4, 2024

Conversation

ProKil
Copy link
Member

@ProKil ProKil commented Oct 4, 2024

Automated Pull Request

ProKil and others added 29 commits May 28, 2024 15:08
…ption for all generation methods, to avoid future OpenAI API changes break Sotopia running. (#196)

* Two major updates: 1) add "bad_output_process_model" option to all `agenerate_xxx()` methods so users can decide which model to use for handling bad outputs. By default, this is set to be `gpt-4o-mini`. 2) add `use_fixed_model_version` option for all generation methods, as some fixed model version may no longer available in the future. Users should have the right to bypass the fixed model version mapping instead of getting stuck in an error. Document (`generation.md`) has been updated for these two major changes correspondingly.

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Chenghao Yang <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@XuhuiZhou XuhuiZhou added the don't merge now Please don't merge or close it right now. label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 40.90909% with 26 lines in your changes missing coverage. Please review.

Project coverage is 70.63%. Comparing base (830c4b0) to head (12e74a6).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
sotopia/generation_utils/generate.py 53.57% 13 Missing ⚠️
sotopia/samplers/uniform_sampler.py 0.00% 8 Missing ⚠️
sotopia/samplers/constraint_based_sampler.py 37.50% 5 Missing ⚠️
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   69.37%   70.63%   +1.25%     
==========================================
  Files          56       56              
  Lines        2971     3347     +376     
==========================================
+ Hits         2061     2364     +303     
- Misses        910      983      +73     
Files with missing lines Coverage Δ
sotopia/agents/generate_agent_background.py 23.33% <ø> (ø)
sotopia/agents/llm_agent.py 43.68% <ø> (ø)
sotopia/envs/parallel.py 78.37% <ø> (ø)
tests/envs/test_parallel.py 100.00% <ø> (ø)
tests/generation_utils/test_generation.py 81.81% <ø> (ø)
tests/sampler/test_sampler.py 100.00% <ø> (ø)
sotopia/samplers/constraint_based_sampler.py 86.11% <37.50%> (-4.80%) ⬇️
sotopia/samplers/uniform_sampler.py 71.79% <0.00%> (-13.06%) ⬇️
sotopia/generation_utils/generate.py 58.07% <53.57%> (+2.76%) ⬆️

... and 4 files with indirect coverage changes

@XuhuiZhou XuhuiZhou self-requested a review October 4, 2024 21:19
@XuhuiZhou XuhuiZhou merged commit 25013e4 into main Oct 4, 2024
15 checks passed
@@ -1,6 +1,6 @@
[tool.poetry]
name = "sotopia"
version = "0.1.0-rc.3"
version = "0.1.0-rc.5"
Copy link
Collaborator

@yufansong yufansong Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why directly junp from 3 to 5 and skip 4 🤔, typo? Seems irreversible but no severe impact.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo yeah, my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge now Please don't merge or close it right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants