fix(logging): Add interactionId to header of Cody Client requests for autoCompletes and autoEdits #6749
Conversation
| @@ -253,6 +253,7 @@ export class AutoeditsProvider implements vscode.InlineCompletionItemProvider, v | |||
| position, | |||
| prompt, | |||
| codeToReplaceData, | |||
| requestId, | |||
There was a problem hiding this comment.
The requestId is different from the stableId we use as the interactionId for auto-edit events. The stableId is derived from the prediction text and is only created once we receive a response from the backend. So, adding this header to requests won’t let us link auto-edit events to the prediction request. Based on the Linear issue description, this might be fine, but I just wanted to flag it here.
| @@ -158,9 +158,10 @@ class FireworksProvider extends Provider { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| const headers = this.getCustomHeaders(authStatus.isFireworksTracingEnabled) | |||
| headers['X-Sourcegraph-Interaction-ID'] = options.completionLogId | |||
There was a problem hiding this comment.
Can we move this logic inside the getCustomHeaders method? Then, this header will also propagate to the fast path client through the createFastPathClient call.
| @@ -27,4 +27,5 @@ export interface AutoeditModelOptions { | |||
| codeToRewrite: string | |||
| userId: string | null | |||
| isChatModel: boolean | |||
| requestId: string | |||
There was a problem hiding this comment.
Let's name it interactionId for clarity. The requestId refers to the analytics logger item ID which represents the current state of the auto-edit request.
This PR adds a fix for add interactionId to header of Cody Client
requests.
interactionIdwas missing in autoCompletes and autoEdits beforeTest plan
'verifies interactionId is passed through chat requests' in ChatController.test.ts