refactor(webviews): chat history tab with pagination #7020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the chat history tab to match prompts tab with several UX improvements: - Add pagination support with configurable items per page - Add export and delete all functionality in the header - Improve search functionality with a cleaner command palette style interface - Remove period-based grouping of chat history items - Add confirmation dialog for delete all action - Make history items more compact and consistent - Add keyboard navigation support - Improve empty state messaging and layout ## Test plan - Verify pagination works correctly with different page sizes - Test search functionality filters correctly - Confirm export and delete all actions work as expected - Check keyboard navigation and accessibility - Verify empty state renders appropriately - Test history item interactions and delete functionality
- Add strict boolean check for human message text filtering - Move filtering logic to avoid duplicate filtering operations - Fix empty state to only show when there are no filtered chats and no search text - Simplify filtered chats logic by combining conditions - Remove unnecessary newline in component
julialeex
requested changes
Feb 26, 2025
| // Ensure the chat view is ready before we start typing | ||
| await expect(sidebarTabHistoryButton).toBeVisible() | ||
| await expect(sidebarChat.getByRole('button', { name: 'Export' })).toBeVisible() | ||
| await expect(sidebarChat.getByRole('button', { name: 'Delete all' })).toBeVisible() |
There was a problem hiding this comment.
Noice Changes! ^o^
Some suggestions
- Can we add some space between the export button and delete all button?
- Can we make the two buttons align with the search bar?
- The export button didn't work when I tested this locally.
- The text colors are white for light Color themes, which are hard to see.
- Can we make the buttons slightly smaller?
|
while we're here, can we make the chat titles editable by the user? |
@alexromano yea that was on my mind as well and I think this is a good building block for that 😃 I can do that in a follow up since I don't think that's urgent? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the chat history tab to match prompts tab with several UX improvements:
Fixed bugs:
Delete AllandExportbuttons show up when chat history is emptyTest plan
Updated unit test and e2e test.
After
20 chats per page
Before
With 400+ chat in my history the list gets too long for scrolling.