refactor(webview): relocate model selector #7288
Open
+102
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the model selection dropdown from the chat editor toolbar to the tab bar for better visibility and accessibility. It also simplifies the logic for determining the "new chat" command. The changes include: - Moving the `ModelSelectField` component from `vscode/webviews/chat/cells/messageCell/human/editor/toolbar/Toolbar.tsx` to `vscode/webviews/tabs/TabsBar.tsx`. - Adding the `models` prop to the `TabsBar` component to pass available models to the `ModelSelectField`. - Removing the `ModelSelectFieldToolbarItem` component. - Adjusting the layout of the `TabsBar` to accommodate the new model selection dropdown. - Simplifying the `getCreateNewChatCommand` function in `vscode/webviews/tabs/utils.ts` to always use `cody.chat.newPanel` instead of `cody.chat.newEditorPanel`. - Adding a tooltip to the "New Chat" button in the tab bar.
|
it definitely looks cleaner! but will take some getting used to i think. can we:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://sourcegraph.slack.com/archives/C08DP4R5CG0/p1740789400315269
part of https://linear.app/sourcegraph/issue/CODY-5194/move-model-selector-to-the-top-nav-bar
Test plan
@julialeex to take over