-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release manifest + QA #1008
Conversation
|
@@ -2,4 +2,5 @@ nodejs 16.7.0 | |||
yarn 1.22.4 | |||
shellcheck 0.7.1 | |||
golang 1.19.8 | |||
github-cli 2.46.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to post on PRs. Tested in CI.
# Therefore, if you update them, or if you decide to change how we detect what kind of build we're dealing | ||
# with, please update this file as well. | ||
- label: "(internal) Release: test" | ||
if: build.branch =~ /^internal\/release-.*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does =~
mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the regexp operator
Add the final layer of paint + QA (internal+promotion).
I reworked how we handle branches, so we have the simplest and safest approach for the next few release cycles:
<any branch>
->internal/release-vX.Y.Z
internal/release-vX.Y.Z
->promote/release-vX.Y.Z
promote/release-vX.Y.Z
torelease-vX.Y.Z
release-vX.Y.Z
branch.The previous flow was:
sg release create ...
would checkout a new branch namedwip_vX.Y.Z
finalize
step would create a new branch namedwip-release-vX.Y.Z
sg release promote-to-public
would checkout a new branch namedpromote-release_vX.Y.Z
wip-release-vX.Y.Z
as the base branch, triggering a CI build for the promotionfinalize
step would tag the commit.Problem: if you decide to merge the final branch that has the tagged commit, you'd end up with a dangling commit, which is risky/scary. This passed the review because back then we overlooked the fact that it's very to just close the PR, to keep things tidy.
Checklist
Test plan