expose async-generator client API #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the client and controller only exposed a "watch" API using RxJS Observables so that callers could subscribe to and watch changes (to mentions, annotations, etc.). This required callers to depend on RxJS, which is a big dependency that can introduce complexity in their own applications. Now, there is a new API `xyzChanges__asyncGenerator` for each of `meta`, `mentions`, `items`, and `annotations` that lets callers just use native async generators. This API is experimental and may be changed without notice.
bevzzz
pushed a commit
to bevzzz/openctx
that referenced
this pull request
Dec 12, 2024
Previously, the client and controller only exposed a "watch" API using RxJS Observables so that callers could subscribe to and watch changes (to mentions, annotations, etc.). This required callers to depend on RxJS, which is a big dependency that can introduce complexity in their own applications. Now, there is a new API `xyzChanges__asyncGenerator` for each of `meta`, `mentions`, `items`, and `annotations` that lets callers just use native async generators. This API is experimental and may be changed without notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the client and controller only exposed a "watch" API using RxJS Observables so that callers could subscribe to and watch changes (to mentions, annotations, etc.). This required callers to depend on RxJS, which is a big dependency that can introduce complexity in their own applications. Now, there is a new API
xyzChanges__asyncGeneratorfor each ofmeta,mentions,items, andannotationsthat lets callers just use native async generators. This API is experimental and may be changed without notice.