Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispose client in createController #189

Merged
merged 1 commit into from
Aug 1, 2024
Merged

dispose client in createController #189

merged 1 commit into from
Aug 1, 2024

Conversation

sqs
Copy link
Member

@sqs sqs commented Jul 31, 2024

No description provided.

keegancsmith
keegancsmith approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll handle bumping vscode-lib and integrating into cody.

@keegancsmith keegancsmith merged commit 14c57d8 into main Aug 1, 2024
11 of 12 checks passed
@keegancsmith keegancsmith deleted the sqs/ctrl-dispose-client branch August 1, 2024 08:34
bevzzz pushed a commit to bevzzz/openctx that referenced this pull request Dec 12, 2024
@sqs @bevzzz
dispose client in createController (sourcegraph#189)
2cd5eb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sqs @keegancsmith