Account for orphaned anchors in framing #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
anchors-orphan
branch
from
7b32526 to
ec84ea3
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos/llvm)
| Benchmark suite | Current: ec84ea3 | Previous: f451b12 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.6410230668056214 ns/iter |
1.5823974356629897 ns/iter |
1.04 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.654134950431246 ns/iter |
1.5792236322760234 ns/iter |
1.05 |
Regex_Period_Asterisk |
1.607081840910256 ns/iter |
1.5901208372624422 ns/iter |
1.01 |
Regex_Group_Period_Asterisk_Group |
1.6833396811837664 ns/iter |
1.5679908041389763 ns/iter |
1.07 |
Regex_Period_Plus |
1.9444068635928713 ns/iter |
1.8880474640881524 ns/iter |
1.03 |
Regex_Period |
1.9231619442335854 ns/iter |
1.8884229537393362 ns/iter |
1.02 |
Regex_Caret_Period_Plus_Dollar |
1.9426026628320106 ns/iter |
1.8823662822989957 ns/iter |
1.03 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.987092795424821 ns/iter |
1.8934401369827738 ns/iter |
1.05 |
Regex_Caret_Period_Asterisk_Dollar |
1.6427180672598147 ns/iter |
1.6131847162172142 ns/iter |
1.02 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.6298067475076643 ns/iter |
1.6343347829208534 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
6.935763298582257 ns/iter |
6.716968981371581 ns/iter |
1.03 |
Regex_Period_Md_Dollar |
70.34642522338802 ns/iter |
69.00366402558244 ns/iter |
1.02 |
Regex_Caret_Slash_Period_Asterisk |
5.200580872541594 ns/iter |
5.01544547558615 ns/iter |
1.04 |
Regex_Caret_Period_Range_Dollar |
2.2787461043986816 ns/iter |
2.196389771703618 ns/iter |
1.04 |
Regex_Nested_Backtrack |
754.261235326765 ns/iter |
727.6337701277114 ns/iter |
1.04 |
JSON_Array_Of_Objects_Unique |
350.13340522005916 ns/iter |
326.849209959637 ns/iter |
1.07 |
JSON_Parse_1 |
22125.402793472407 ns/iter |
21200.20805206173 ns/iter |
1.04 |
JSON_Fast_Hash_Helm_Chart_Lock |
48.10776417150172 ns/iter |
47.6762746261962 ns/iter |
1.01 |
JSON_Equality_Helm_Chart_Lock |
123.8510374715306 ns/iter |
118.30648139660828 ns/iter |
1.05 |
JSON_String_Equal/10 |
7.823258520824075 ns/iter |
7.580078496085359 ns/iter |
1.03 |
JSON_String_Equal/100 |
6.199761733174709 ns/iter |
6.015585770637665 ns/iter |
1.03 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.32361029380147166 ns/iter |
0.31368847349680695 ns/iter |
1.03 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.0317049106482767 ns/iter |
2.9614754343176783 ns/iter |
1.02 |
JSON_String_Fast_Hash/10 |
1.5754941522255816 ns/iter |
1.5937970652054707 ns/iter |
0.99 |
JSON_String_Fast_Hash/100 |
1.8797438278100465 ns/iter |
1.9126330567981729 ns/iter |
0.98 |
JSON_String_Key_Hash/10 |
1.2570021756812855 ns/iter |
1.2862512399143147 ns/iter |
0.98 |
JSON_String_Key_Hash/100 |
1.2868259755324647 ns/iter |
1.3050246457354946 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Same_Length |
2.2256222078783616 ns/iter |
2.2952967443897676 ns/iter |
0.97 |
JSON_Object_Defines_Miss_Too_Small |
2.384498990698828 ns/iter |
2.3338922727446922 ns/iter |
1.02 |
JSON_Object_Defines_Miss_Too_Large |
2.2710875266030057 ns/iter |
2.3462516058295333 ns/iter |
0.97 |
Pointer_Object_Traverse |
17.770650958567654 ns/iter |
17.740503213279812 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
21.723279416624006 ns/iter |
23.535227513853794 ns/iter |
0.92 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
170.06394057367697 ns/iter |
172.6227609223971 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: ec84ea3 | Previous: f451b12 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.1838537740333988 ns/iter |
2.1945396465688587 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.1828786195211793 ns/iter |
2.1800350425835573 ns/iter |
1.00 |
Regex_Period_Asterisk |
2.1855545383054786 ns/iter |
2.1818609435404905 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
2.1791835703305464 ns/iter |
2.180813820695279 ns/iter |
1.00 |
Regex_Period_Plus |
2.796074633744834 ns/iter |
2.800361023406497 ns/iter |
1.00 |
Regex_Period |
2.797459766805837 ns/iter |
2.8044021572710562 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
2.7972390547778314 ns/iter |
2.8004023482006555 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.797904378639386 ns/iter |
2.8004261232215564 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
3.417187434574803 ns/iter |
3.418899251589838 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.418220506295523 ns/iter |
3.4498078074255676 ns/iter |
0.99 |
Regex_Caret_X_Hyphen |
12.534525367043726 ns/iter |
12.586009562228433 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
81.4042958036675 ns/iter |
81.7865820366206 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
6.840745051214504 ns/iter |
6.835205984135196 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.037995708009174 ns/iter |
4.044262435040536 ns/iter |
1.00 |
Regex_Nested_Backtrack |
502.4765650000518 ns/iter |
506.958286283906 ns/iter |
0.99 |
JSON_Array_Of_Objects_Unique |
404.40277532077766 ns/iter |
408.8383860118813 ns/iter |
0.99 |
JSON_Parse_1 |
30350.980712806242 ns/iter |
30887.918767504947 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
59.39035124348108 ns/iter |
59.24956942074235 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
150.8793246346755 ns/iter |
162.37466414166764 ns/iter |
0.93 |
JSON_String_Equal/10 |
6.232005116679961 ns/iter |
7.415570786708916 ns/iter |
0.84 |
JSON_String_Equal/100 |
6.846715266860735 ns/iter |
6.65103834636153 ns/iter |
1.03 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9347648193904854 ns/iter |
0.9347516512286913 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
10.278541053404805 ns/iter |
10.259248669435674 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
2.487279115009703 ns/iter |
2.4911850371757276 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.4856520167622644 ns/iter |
2.4866280835722914 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.180229663905228 ns/iter |
2.177761874178524 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
1.8691816300143391 ns/iter |
1.866550091452849 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.7366145093985876 ns/iter |
3.7362967502817255 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7565813937574526 ns/iter |
3.749769432757481 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.74057262766526 ns/iter |
3.7349660752003295 ns/iter |
1.00 |
Pointer_Object_Traverse |
45.90265878922057 ns/iter |
45.612236618246634 ns/iter |
1.01 |
Pointer_Object_Try_Traverse |
52.29315594763456 ns/iter |
52.32379959681736 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
1124.493554496446 ns/iter |
354.62856166483675 ns/iter |
3.17 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
| Benchmark suite | Current: ec84ea3 | Previous: f451b12 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
7.044838169643392 ns/iter |
7.219411830356697 ns/iter |
0.98 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.06968861607038 ns/iter |
6.925809151786058 ns/iter |
1.02 |
Regex_Period_Asterisk |
7.088156249999145 ns/iter |
6.882424107143491 ns/iter |
1.03 |
Regex_Group_Period_Asterisk_Group |
7.234249521277631 ns/iter |
7.1243247767860405 ns/iter |
1.02 |
Regex_Period_Plus |
8.939700892856958 ns/iter |
7.251178571429254 ns/iter |
1.23 |
Regex_Period |
7.190014508928755 ns/iter |
7.223306919642728 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
7.3139787946427 ns/iter |
7.243949776785742 ns/iter |
1.01 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
7.264863839286611 ns/iter |
7.252013392856479 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
7.085623883928654 ns/iter |
7.066968749999601 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
6.861661830358048 ns/iter |
6.99098883928606 ns/iter |
0.98 |
Regex_Caret_X_Hyphen |
11.784057812501914 ns/iter |
14.261769579189705 ns/iter |
0.83 |
Regex_Period_Md_Dollar |
149.84830357143153 ns/iter |
153.79051339284695 ns/iter |
0.97 |
Regex_Caret_Slash_Period_Asterisk |
10.311712499998293 ns/iter |
10.602607812499443 ns/iter |
0.97 |
Regex_Caret_Period_Range_Dollar |
7.5245236271204625 ns/iter |
7.70346291203878 ns/iter |
0.98 |
Regex_Nested_Backtrack |
610.0280357143463 ns/iter |
626.8223214285789 ns/iter |
0.97 |
JSON_Array_Of_Objects_Unique |
489.61850000000595 ns/iter |
489.93642857137075 ns/iter |
1.00 |
JSON_Parse_1 |
80622.17758137708 ns/iter |
79900.98214286486 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
69.06137500000195 ns/iter |
67.59968749999449 ns/iter |
1.02 |
JSON_Equality_Helm_Chart_Lock |
188.159856085686 ns/iter |
188.1130014361391 ns/iter |
1.00 |
JSON_String_Equal/10 |
8.992343263425548 ns/iter |
9.010604424058645 ns/iter |
1.00 |
JSON_String_Equal/100 |
9.920141473570412 ns/iter |
9.994822723237872 ns/iter |
0.99 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
2.169989374999659 ns/iter |
2.1723656249999834 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.61568526785584 ns/iter |
14.623500571716413 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
4.030350542911488 ns/iter |
4.033412507202328 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
4.024777373258168 ns/iter |
4.026911346476089 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
8.292025409409817 ns/iter |
7.978367375096563 ns/iter |
1.04 |
JSON_String_Key_Hash/100 |
4.030351703626696 ns/iter |
4.028875000000123 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
3.7144307076531997 ns/iter |
3.727519279058485 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
4.98139700000138 ns/iter |
4.9607639999999265 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.4082016903433328 ns/iter |
3.4353382974367705 ns/iter |
0.99 |
Pointer_Object_Traverse |
50.43645999999171 ns/iter |
49.207696428571325 ns/iter |
1.02 |
Pointer_Object_Try_Traverse |
67.76505357141868 ns/iter |
67.77617187500188 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
177.79767708468017 ns/iter |
161.55740367571894 ns/iter |
1.10 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: ec84ea3 | Previous: f451b12 | Ratio |
|---|---|---|---|
Pointer_Object_Traverse |
45.12333348686602 ns/iter |
45.21920492649728 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
26.166583367046083 ns/iter |
26.143930232127975 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
145.07652181905655 ns/iter |
145.18234344430715 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
409.823408280448 ns/iter |
430.81569650482186 ns/iter |
0.95 |
JSON_Parse_1 |
33036.5729092743 ns/iter |
33115.992105139856 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.91733273580739 ns/iter |
68.73636530544626 ns/iter |
0.92 |
JSON_Equality_Helm_Chart_Lock |
149.209444196112 ns/iter |
149.1392622878646 ns/iter |
1.00 |
JSON_String_Equal/10 |
6.346690978261154 ns/iter |
6.333038318720798 ns/iter |
1.00 |
JSON_String_Equal/100 |
6.959855027944088 ns/iter |
6.955143312102082 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.935040978157197 ns/iter |
0.9342951024911924 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.291201591213968 ns/iter |
14.288575931079636 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
0.9327717184561427 ns/iter |
0.93422638789911 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
0.9335208892243081 ns/iter |
0.9336521951868131 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
1.6731733521501992 ns/iter |
1.6715690650104214 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
1.9837163491906575 ns/iter |
1.9827939881481564 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
2.49190024951756 ns/iter |
2.485494106926353 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
2.486747769169169 ns/iter |
2.48653207488322 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.1086455535288278 ns/iter |
3.1104358262127616 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
3.4198843418114167 ns/iter |
3.419261026353197 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
3.4400414378346182 ns/iter |
3.4212772223582415 ns/iter |
1.01 |
Regex_Period_Asterisk |
3.4231167365708997 ns/iter |
3.4293043978711424 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
3.4205180954687213 ns/iter |
3.4192436302440345 ns/iter |
1.00 |
Regex_Period_Plus |
3.7335871650617545 ns/iter |
3.583854466627948 ns/iter |
1.04 |
Regex_Period |
3.7319089073550886 ns/iter |
3.4318338065780707 ns/iter |
1.09 |
Regex_Caret_Period_Plus_Dollar |
3.7296381012120072 ns/iter |
3.41743642753243 ns/iter |
1.09 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.7409393086493252 ns/iter |
3.4232411199523063 ns/iter |
1.09 |
Regex_Caret_Period_Asterisk_Dollar |
4.663215724934001 ns/iter |
3.7356271854367322 ns/iter |
1.25 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
4.667235169413269 ns/iter |
3.729588904175153 ns/iter |
1.25 |
Regex_Caret_X_Hyphen |
13.09387942978218 ns/iter |
13.103924192441145 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
91.20292254336904 ns/iter |
90.90421485551762 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
8.089006089364405 ns/iter |
8.09372829300998 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.664695794911418 ns/iter |
4.661432185957052 ns/iter |
1.00 |
Regex_Nested_Backtrack |
859.8653755926752 ns/iter |
816.479347936895 ns/iter |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/gcc)
| Benchmark suite | Current: ec84ea3 | Previous: f451b12 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.9674742907621696 ns/iter |
1.883786469334703 ns/iter |
1.04 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.958560744481178 ns/iter |
1.887828382898557 ns/iter |
1.04 |
Regex_Period_Asterisk |
1.9396842541685537 ns/iter |
1.8946323837306474 ns/iter |
1.02 |
Regex_Group_Period_Asterisk_Group |
1.9599524650514482 ns/iter |
1.8832737753707207 ns/iter |
1.04 |
Regex_Period_Plus |
1.7464038646471451 ns/iter |
1.5701402263500484 ns/iter |
1.11 |
Regex_Period |
1.669435143115313 ns/iter |
1.568878948408738 ns/iter |
1.06 |
Regex_Caret_Period_Plus_Dollar |
1.730454219957033 ns/iter |
1.5674984128254799 ns/iter |
1.10 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.6657721139496418 ns/iter |
1.5674117435833832 ns/iter |
1.06 |
Regex_Caret_Period_Asterisk_Dollar |
1.9855512735796517 ns/iter |
1.8805678525433867 ns/iter |
1.06 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.9937539364399817 ns/iter |
1.8818580103225009 ns/iter |
1.06 |
Regex_Caret_X_Hyphen |
6.506929897868141 ns/iter |
5.968935472818755 ns/iter |
1.09 |
Regex_Period_Md_Dollar |
73.07048803725527 ns/iter |
68.19813826674113 ns/iter |
1.07 |
Regex_Caret_Slash_Period_Asterisk |
4.477036655437619 ns/iter |
4.582263975428606 ns/iter |
0.98 |
Regex_Caret_Period_Range_Dollar |
1.9427311576029795 ns/iter |
1.8909185425646302 ns/iter |
1.03 |
Regex_Nested_Backtrack |
920.383158185755 ns/iter |
814.6029932484505 ns/iter |
1.13 |
JSON_Array_Of_Objects_Unique |
264.5466239249333 ns/iter |
213.39421177903625 ns/iter |
1.24 |
JSON_Parse_1 |
24611.48497852996 ns/iter |
22937.913016717015 ns/iter |
1.07 |
JSON_Fast_Hash_Helm_Chart_Lock |
25.81393850936682 ns/iter |
23.707764788380747 ns/iter |
1.09 |
JSON_Equality_Helm_Chart_Lock |
125.38490073673711 ns/iter |
113.29868774314683 ns/iter |
1.11 |
JSON_String_Equal/10 |
5.743148453209121 ns/iter |
5.375248466551263 ns/iter |
1.07 |
JSON_String_Equal/100 |
5.323967281331172 ns/iter |
5.05480729406041 ns/iter |
1.05 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.8007290523581839 ns/iter |
0.7450218460502598 ns/iter |
1.07 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.7559390831718273 ns/iter |
3.4503216910896124 ns/iter |
1.09 |
JSON_String_Fast_Hash/10 |
1.9861149524661996 ns/iter |
1.8902485979690375 ns/iter |
1.05 |
JSON_String_Fast_Hash/100 |
1.981661743054405 ns/iter |
1.9287400098279723 ns/iter |
1.03 |
JSON_String_Key_Hash/10 |
1.519417011322847 ns/iter |
1.454179584004509 ns/iter |
1.04 |
JSON_String_Key_Hash/100 |
1.999806087870962 ns/iter |
1.921735666331047 ns/iter |
1.04 |
JSON_Object_Defines_Miss_Same_Length |
1.8446720952532045 ns/iter |
1.7262912314312098 ns/iter |
1.07 |
JSON_Object_Defines_Miss_Too_Small |
2.106020748960442 ns/iter |
1.882140763543681 ns/iter |
1.12 |
JSON_Object_Defines_Miss_Too_Large |
2.0264735172440114 ns/iter |
1.728587901525002 ns/iter |
1.17 |
Pointer_Object_Traverse |
57.93220327049084 ns/iter |
52.08504569296174 ns/iter |
1.11 |
Pointer_Object_Try_Traverse |
39.2312459166375 ns/iter |
35.99578384304012 ns/iter |
1.09 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
164.23405018900556 ns/iter |
157.51931690335007 ns/iter |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]