-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Incorporate gomega matchers #3489
test: Incorporate gomega matchers #3489
Conversation
These are examples of how failed tests look:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3489 +/- ##
===========================================
+ Coverage 78.48% 78.49% +0.01%
===========================================
Files 397 397
Lines 37599 37599
===========================================
+ Hits 29506 29510 +4
+ Misses 6399 6397 -2
+ Partials 1694 1692 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looking forward to see how this might impact our tests in the future.
Relevant issue(s)
Resolves #3189
Description
Replace the
Validator
interface withgomega.OmegaMatcher
that doesn't assert directly, but instead matches the actual value against the expected value and returnsbool
as a result. This allows different matchers to be combined.Moreover, gomega provides a number of very handy matchers that we can use.