feat: expose bls12-381 G1 curve commitments ( PROOF-667 ) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test for compute_bls12_381_g1_commitments_with_generators
* remove conversion to projective elements in compute_bls12_381_g1_commitments_with_generators
rnburn
reviewed
Oct 27, 2023
| /// | ||
| ///# Example 1 - Pass generators to Commitment Computation | ||
| ///```no_run | ||
| #[doc = include_str!("../../examples/pass_generators_to_commitment.rs")] |
There was a problem hiding this comment.
Why are you referencing these examples? Aren't those for curve-25519?
There was a problem hiding this comment.
Yes, they do refer to curve-25519. I am referencing those for two reasons.
- The
doctag doesn't seem to be working, see PROOF-708. I want to get that fixed before I write the documentation. I'm not positive how to test formatting without understanding how thedoctag should appear. For example, I don't know if I can use the samemdfile to document both functions, or need a separatemdfile? - If I remove the
doctags,cargothrows an error:error: missing documentation for a function.
Here is how the doc tag appears now when hovering over a function.
And blitzar doesn't have a Documents section on crates.io.
I was hoping to avoid scope creep on this PR.
There was a problem hiding this comment.
If you need the tags as a placeholder, please indicate so with a comment so that someone looking at the code understand why they're there.
There was a problem hiding this comment.
Great idea. Added.
rnburn
approved these changes
Oct 30, 2023
jacobtrombetta
deleted the
feat/bls12_381_g1_curve_commitments-PROOF-667
branch
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to expose commitment computation with bls12-381 elements,
blitzar-rsneeds to implement a method in the commitments module. This PR does that work.Notes for follow up work.
doctag is not behaving as expected. A bug has been entered to investigate. See PROOF-708.compute_bls12_381_g1_commitments_with_generators. See PROOF-710.What changes are included in this PR?
compute_bls12_381_g1_commitments_with_generatorsis added to the commitments module.blitzar-sysversion is bumped to1.3.3.Are these changes tested?
Yes.
Note, scalar elements for the bls12-381 curve are in Montgomery form. A test similar to
sending_generators_and_scalars_to_gpu_produces_correct_commitment_resultswas not written at this time. The.into()method needs implement a method to convert[Fp<MontBackend<T, N>, N>]toBigInt<N>in order to pass the correct values to theSequenceparameter. The Sequence module does have an optional BigIntFromimplementation.