bench: create primitive benchmark for bls12-381 curve and field addition (PROOF-804) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Running benchmarks on primitives will help us identify where to improve our code. The work adds primitive benchmarks for
bls12-381curve and field element addition.What changes are included in this PR?
primitivescomponent is added to the benchmark folder.bls12-381curve operation package group,curve_g1.curve_g1/property/curvecomponent is updated to beCUDA_CALLABLE.Are these changes tested?
Yes on a local machine and the Multi-T4.