feat: add version of bucket method for many outputs (PROOF-642) #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #include "sxt/base/curve/example_element.h" | ||
| #include "sxt/base/device/synchronization.h" | ||
| #include "sxt/base/test/unit_test.h" | ||
| #include "sxt/curve21/operation/add.h" |
There was a problem hiding this comment.
It looks like all the tests use the bascrv::element97 component. Do need to include anything from curve21 or field51 here?
There was a problem hiding this comment.
Added a test for curve21. Thank you.
jacobtrombetta
approved these changes
Mar 5, 2024
|
🎉 This PR is included in version 1.38.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add version of the bucket method that is more efficient for the case of short multi-exponentiations with many outputs.
What changes are included in this PR?
Updates the multiexponentiation code to use the new bucket methods if the problem dimensions suggest it makes sense.
Are these changes tested?
Yes