feat: add field25 type package (PROOF-775) #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnburn
approved these changes
Jan 10, 2024
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to support MSM with elements on the
bn254curve we need to implement the base fieldFq. This work will introduce the type package and components to thebn254base field,field25. The components are copied from the thefield12/typepackage, which supports thebls12-381curve. The components are updated to support thebn254base field, which is four limbs, compared to the six limbs of thebls12-381base field.The only non-trivial code change, which updated the limbs from six to four, is isolated to this commit.
What changes are included in this PR?
elementandliteralcomponents are copied from thefield12/typepackage and updated to support the four limbs.Are these changes tested?
Yes