feat: add bn254 G1 curve operations cmov, double, and mul_by_3b (PROOF-739) #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnburn
approved these changes
Jan 22, 2024
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to support MSM with
G1elements on thebn254curve we need to implement the curve package. This work will introduce thebn254operation package along with thecmov,double, andmul_by_3bcomponents. The components are copied from the thecurve_g1/operationpackage, which supports thebls12-381curve. The components are updated to support thebn254G1curve.Non-trivial changes are isolated to this commit.
What changes are included in this PR?
curve_bng1.curve_g1are copied over tocurve_bng1.cmov,double, andmul_by_3bcomponents are updated to support thebn254G1curve.Are these changes tested?
Yes