chore: fix comment format in the bls12-381 packages (PROOF-784) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnburn
reviewed
Jan 22, 2024
sxt/cbindings/backend/cpu_backend.h
Outdated
| @@ -36,7 +36,7 @@ struct element_p3; | |||
|
|
|||
| namespace sxt::cg1t { | |||
| class compressed_element; | |||
| struct element_p3; | |||
| struct element_p2; | |||
There was a problem hiding this comment.
You should be able to drop these forward declarations since they should be defined in the included backend.h header
There was a problem hiding this comment.
Good call, I removed all the forward declarations in cpu_ backend.h and gpu_backend.h.
jacobtrombetta
force-pushed
the
chore/fix-comment-format-PROOF-784
branch
from
009a044 to
24b2ae1
Compare
rnburn
approved these changes
Jan 22, 2024
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The comment format in the
bls12-381packages should match the comment format in thecurve25519packages.What changes are included in this PR?
curve_g1andfield12packages.cg1tnamespace in both thecpu_backend.handgpu_backend.hfiles.Are these changes tested?
Yes