Add remaining tests

spacemeshos · Nov 4, 2024 · 1ada05c · 1ada05c
1 parent 89fa079
commit 1ada05c
Show file tree

Hide file tree

Showing 3 changed files with 474 additions and 100 deletions.
diff --git a/activation/wire/malfeasance_invalid_post.go b/activation/wire/malfeasance_invalid_post.go
@@ -53,6 +53,10 @@ func NewInvalidPostProof(
 		return nil, errors.New("ATX is not a merged ATX, but NodeID is different from SmesherID")
 	}
 
+	if nipostIndex < 0 || nipostIndex >= len(atx.NIPosts) {
+		return nil, errors.New("invalid NIPoST index")
+	}
+
 	postIndex := 0
 	var marriageProof *MarriageProof
 	if atx.SmesherID != nodeID {
@@ -65,7 +69,7 @@ func NewInvalidPostProof(
 			return post.MarriageIndex == proof.NodeIDMarryProof.CertificateIndex
 		})
 		if postIndex == -1 {
-			return nil, errors.New("marriage index not found in PoSTs of ATX")
+			return nil, fmt.Errorf("no PoST from %s in ATX", nodeID.ShortString())
 		}
 	}
 
@@ -234,6 +238,9 @@ func createInvalidPostProof(
 	if nipostIndex < 0 || nipostIndex >= len(atx.NIPosts) {
 		return InvalidPostProof{}, errors.New("invalid NIPoST index")
 	}
+	if postIndex < 0 || postIndex >= len(atx.NIPosts[nipostIndex].Posts) {
+		return InvalidPostProof{}, errors.New("invalid PoST index")
+	}
 
 	return InvalidPostProof{
 		NIPostsRoot:      atx.NIPosts.Root(atx.PreviousATXs),