-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync2: dbset: use single connection for each sync session #6446
Open
ivan4th
wants to merge
8
commits into
develop
Choose a base branch
from
sync2/dbset-conns
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 11, 2024
-
sql: add Database.Connection/WithConnection, interface cleanup
This adds a possibility to take a connection from the pool to use it via the Executor interface, and return it later when it's no longer needed. This avoids connection pool overhead in cases when a lot of quries need to be made, but the use of read transactions is not needed. Using read transactions instead of simple connections has the side effect of blocking WAL checkpoints.
Configuration menu - View commit details
-
Copy full SHA for ca2d5c6 - Browse repository at this point
Copy the full SHA ca2d5c6View commit details -
sync2: dbset: use single connection for each sync session
Using single connection for multiple SQL queries which are executed during sync avoids noticeable overhead due to SQLite connection pool delays. Also, this change fixes memory overuse in DBSet. When initializing DBSet from a database table, there's no need to use an FPTree with big preallocated pool for the new entries that are added during recent sync.
Configuration menu - View commit details
-
Copy full SHA for 6e3aa16 - Browse repository at this point
Copy the full SHA 6e3aa16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4984889 - Browse repository at this point
Copy the full SHA 4984889View commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bb31cc6 - Browse repository at this point
Copy the full SHA bb31cc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e5a401 - Browse repository at this point
Copy the full SHA 3e5a401View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2753560 - Browse repository at this point
Copy the full SHA 2753560View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5cae06 - Browse repository at this point
Copy the full SHA f5cae06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e585e5 - Browse repository at this point
Copy the full SHA 9e585e5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.