Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-split] Add command for starting services #6625

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Jan 16, 2025

Closes #6618

Note

This PR is not yet removing the old method of starting the node. It should probably be replaced with "combined" mode if we want to keep it as a transition way to new approach.

Also parameters configuration is kept untouched so in activation service mode code is expecting that user will provide --node-service-address while in node service mode the code is expecting that this variable would be NOT set.

@jellonek jellonek force-pushed the node-split/single-binary-multiple-commands branch 3 times, most recently from 1204f9b to f083f1d Compare January 16, 2025 13:51
@jellonek jellonek marked this pull request as ready for review January 16, 2025 13:51
@pigmej
Copy link
Member

pigmej commented Jan 16, 2025

This needs to be added to the changelog.md ;)

@jellonek jellonek force-pushed the node-split/single-binary-multiple-commands branch from f083f1d to 302fac9 Compare January 16, 2025 13:59
@jellonek
Copy link
Contributor Author

CHANGELOG.md updated.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 45.42683% with 537 lines in your changes missing coverage. Please review.

Please upload report for BASE (node-split-poc@837e7fa). Learn more about missing BASE report.
Report is 15 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
node/smeshing_service.go 0.0% 484 Missing ⚠️
node/node.go 89.4% 44 Missing and 9 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             node-split-poc   #6625   +/-   ##
================================================
  Coverage                  ?   77.1%           
================================================
  Files                     ?     377           
  Lines                     ?   51830           
  Branches                  ?       0           
================================================
  Hits                      ?   40011           
  Misses                    ?    9451           
  Partials                  ?    2368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poszu poszu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great start!

Next thing I'd imagine removing all smeshing-related stuff which is not needed on the node-service from the node_service.go (like atx builder, POST initialization etc.).

node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
node/activation_service.go Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
cmd/node/main.go Show resolved Hide resolved
node/smeshing_service.go Outdated Show resolved Hide resolved
@jellonek jellonek merged commit ef83c0c into node-split-poc Jan 17, 2025
15 checks passed
@jellonek jellonek deleted the node-split/single-binary-multiple-commands branch January 17, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants