-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node-split] Add command for starting services #6625
[node-split] Add command for starting services #6625
Conversation
1204f9b
to
f083f1d
Compare
This needs to be added to the changelog.md ;) |
f083f1d
to
302fac9
Compare
CHANGELOG.md updated. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## node-split-poc #6625 +/- ##
================================================
Coverage ? 77.1%
================================================
Files ? 377
Lines ? 51830
Branches ? 0
================================================
Hits ? 40011
Misses ? 9451
Partials ? 2368 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great start!
Next thing I'd imagine removing all smeshing-related stuff which is not needed on the node-service from the node_service.go
(like atx builder, POST initialization etc.).
Closes #6618
Note
This PR is not yet removing the old method of starting the node. It should probably be replaced with "combined" mode if we want to keep it as a transition way to new approach.
Also parameters configuration is kept untouched so in activation service mode code is expecting that user will provide
--node-service-address
while in node service mode the code is expecting that this variable would be NOT set.