Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-split] Setup only localDB for smeshing-service #6641

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

jellonek
Copy link
Contributor

Closes #6639

@jellonek jellonek force-pushed the node-split/setupDBs branch from 3e8917e to 3eb6982 Compare January 18, 2025 19:16
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (ef83c0c) to head (3eb6982).
Report is 2 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
node/node.go 70.0% 2 Missing and 1 partial ⚠️
node/smeshing_service.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           node-split-poc   #6641     +/-   ##
================================================
- Coverage            77.2%   77.1%   -0.1%     
================================================
  Files                 377     377             
  Lines               51830   51839      +9     
================================================
- Hits                40050   40013     -37     
- Misses               9416    9455     +39     
- Partials             2364    2371      +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jellonek jellonek merged commit f31f02b into node-split-poc Jan 20, 2025
15 of 16 checks passed
@jellonek jellonek deleted the node-split/setupDBs branch January 20, 2025 13:49
jellonek added a commit that referenced this pull request Jan 21, 2025
poszu added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants