Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log error when failed to read POS data from file #517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Mar 7, 2025

Added an error log message that will print:

  • the path of the file that it failed to read from,
  • the position in this file
  • the total size of the file
  • the actual error

Previously, the error was swallowed without notifying the user something was wrong.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.03%. Comparing base (8bd1370) to head (51cf87c).

Files with missing lines Patch % Lines
src/reader.rs 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   93.09%   93.03%   -0.07%     
==========================================
  Files          29       29              
  Lines        3621     3632      +11     
==========================================
+ Hits         3371     3379       +8     
- Misses        250      253       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants