-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Allied Vision Camera service to make it work with the new VimbaX software #222
Conversation
I tested the VimbaX migration on the THD2 testbed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the concrete tests you ran to make sure the migration works and does not introduce any issues?
For now, I opened the service in a terminal, and sent some commands though an ipython terminal. I also opened the GUI and the corresponding viewer, to go and test to change the exposure time, the width of the frame, ... |
Ok great! Could you also run some of the example scripts over in thd-controls to make sure they run without any problem? I want to make sure there's no detail we didn't catch in this transition, even if it looks very non-invasive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks for all the detailed test results! This is good to go.
Fixes #223 and https://github.com/ivalaginja/thd-controls/issues/108.