Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Allied Vision Camera service to make it work with the new VimbaX software #222

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

erinpougheon
Copy link
Collaborator

@erinpougheon erinpougheon commented Jul 8, 2024

@erinpougheon erinpougheon added the enhancement New feature or request label Jul 8, 2024
@erinpougheon erinpougheon self-assigned this Jul 8, 2024
@erinpougheon
Copy link
Collaborator Author

I tested the VimbaX migration on the THD2 testbed.
After installing everything that is required on the thd-controller PC, I did some testes and the required changes in the service.
I also updated the documentation file.

@erinpougheon erinpougheon requested a review from ivalaginja July 8, 2024 10:11
Copy link
Collaborator

@ivalaginja ivalaginja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the concrete tests you ran to make sure the migration works and does not introduce any issues?

@erinpougheon
Copy link
Collaborator Author

What are the concrete tests you ran to make sure the migration works and does not introduce any issues?

For now, I opened the service in a terminal, and sent some commands though an ipython terminal. I also opened the GUI and the corresponding viewer, to go and test to change the exposure time, the width of the frame, ...

@ivalaginja
Copy link
Collaborator

What are the concrete tests you ran to make sure the migration works and does not introduce any issues?

For now, I opened the service in a terminal, and sent some commands though an ipython terminal. I also opened the GUI and the corresponding viewer, to go and test to change the exposure time, the width of the frame, ...

Ok great! Could you also run some of the example scripts over in thd-controls to make sure they run without any problem? I want to make sure there's no detail we didn't catch in this transition, even if it looks very non-invasive.

@erinpougheon
Copy link
Collaborator Author

I ran some further tests on the Allied Vision Cameras (the visitor camera and LOWFS camera).
1 - the take_exposure.py example. Here is a screenshot of the result, the test is successful.
image (7)
2 - the take_calibrated_image.py example. Here is a screenshot of the result, the test is successful (even if the image is saturated !)
image (8)
3 - I ran the autoexpose function, with the autoexpose_test script. The result was 252.485 us for target 0.5 and 15 percent. It is coherent and the wanted result.
4 - Finally, I ran the TT controller loop on the LOWFS camera, and it worked too :)
image (9)

All tests are successful and the migration to VimbaX doesn't seem to cause any problem and the Allied Vision Cameras.

@erinpougheon erinpougheon requested a review from ivalaginja July 9, 2024 08:06
Copy link
Collaborator

@ivalaginja ivalaginja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for all the detailed test results! This is good to go.

@erinpougheon erinpougheon merged commit c0b977c into develop Jul 9, 2024
6 checks passed
@erinpougheon erinpougheon deleted the feature/vimbax_migration branch July 9, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt Allied Vision Camera service to VimbaX
2 participants