Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makes thorlabs_tsp01 temperature sensor heads optional per configuration #271

Merged
merged 2 commits into from
Dec 11, 2024
Merged

makes thorlabs_tsp01 temperature sensor heads optional per configuration #271

merged 2 commits into from
Dec 11, 2024

Conversation

lanemeier7
Copy link
Collaborator

Closes #270 by making the Thorlabs tsp01 temperature sensor probes optional via services.yml configuration.

tsp01_1:
  service_type: thorlabs_tsp01
  simulated_service_type: thorlabs_tsp01_sim
  requires_safety: false
  serial_number: M00797061
  num_averaging: 1
  interval: 1
  read_out_header_1: true
  read_out_header_2: false

@lanemeier7 lanemeier7 requested a review from ehpor December 11, 2024 22:29
@lanemeier7 lanemeier7 linked an issue Dec 11, 2024 that may be closed by this pull request
Thorlabs tsp01 service main expects 2 external temp sensors #270
Closed
ehpor
ehpor requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@ehpor ehpor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change. The ternary makes it non-trivial to read what is going on.

catkit2/services/thorlabs_tsp01/thorlabs_tsp01.py Outdated Show resolved Hide resolved
ehpor
ehpor approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@ehpor ehpor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the default of True too.

@lanemeier7 lanemeier7 merged commit 8733f46 into develop Dec 11, 2024
6 checks passed
@lanemeier7 lanemeier7 deleted the 270-thorlabs-tsp01-service-main-expects-2-external-temp-sensors branch December 11, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehpor ehpor ehpor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thorlabs tsp01 service main expects 2 external temp sensors
2 participants
@lanemeier7 @ehpor