fix __str__ for wcs with a None transform #489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructing a WCS without a transform leads to an error for
str(wcs)
:This PR updates
WCS.__str__
to handle this case so the output is now:The issue was found due to usage of a wcs without a transform in roman_datamodels maker_utils combined with an update to
asdf.info
that uses thestr
representation of objects: asdf-format/asdf#1687This PR includes a test for a wcs without a transform. It appears that
WCS.__str__
is otherwise untested so it might be an improvement to add other wcs configurations to the new test.