fix: DataMenu keeps scrolling in view after app is out of view

spacetelescope · Jan 16, 2025 · 08f8634 · 08f8634
1 parent 87016c7
commit 08f8634
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/jdaviz/configs/default/plugins/data_menu/data_menu.vue b/jdaviz/configs/default/plugins/data_menu/data_menu.vue
@@ -297,6 +297,7 @@
         }
         element = element.parentElement;
       }
+      this.jupyterLabCell = this.$el.closest(".jp-Notebook-cell");
     },
     beforeDestroy() {
       let element = document.getElementById(`dm-target-${this.viewer_id}`).parentElement
@@ -325,6 +326,11 @@
         if (this.data_menu_open && document.getElementById(`dm-target-${this.viewer_id}`)) {
           const menuContent = document.getElementById(`dm-content-${this.viewer_id}`);
           menuContent.parentElement.style.top = top + "px";
+
+          /* since Jupyter Lab 4.2 cells outside the view port get a height of 0, causing the menu to be visible when
+           * that happens. This workaround hides the menu when it's parent cell is not in the viewport. */
+          const labCellHidden = this.jupyterLabCell && window.getComputedStyle(this.jupyterLabCell).height === "0px";
+          menuContent.parentElement.style.display = labCellHidden ? "none" : "";
         }
       },
       boolToString(b) {