add API test

spacetelescope · Oct 24, 2024 · 43b2123 · 43b2123
1 parent fc62e99
commit 43b2123
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/jdaviz/configs/specviz/plugins/unit_conversion/tests/test_unit_conversion.py b/jdaviz/configs/specviz/plugins/unit_conversion/tests/test_unit_conversion.py
@@ -165,6 +165,13 @@ def test_mosviz_profile_view_mouseover(specviz2d_helper, spectrum2d):
     viewer = specviz2d_helper.app.get_viewer("spectrum-viewer")
     plg = specviz2d_helper.plugins["Unit Conversion"]
 
+    # make sure we don't expose angle, sb, nor spectral-y units when native
+    # units are in flux
+    assert hasattr(plg, 'flux_unit')
+    assert not hasattr(plg, 'angle_unit')
+    assert not hasattr(plg, 'sb_unit')
+    assert not hasattr(plg, 'spectral_y_type')
+
     label_mouseover = specviz2d_helper.app.session.application._tools['g-coords-info']
     label_mouseover._viewer_mouse_event(viewer,
                                         {'event': 'mousemove',

diff --git a/jdaviz/core/helpers.py b/jdaviz/core/helpers.py
@@ -495,10 +495,6 @@ def _handle_display_units(self, data, use_display_units=True):
 
                 else:
                     new_uncert = None
-                if ('_pixel_scale_factor' in data.meta):
-                    new_y = flux_conversion(data.flux.value, data.flux.unit,
-                                            y_unit, spec=data) * u.Unit(y_unit)
-                else:
                     new_y = flux_conversion(data.flux.value, data.flux.unit,
                                             y_unit, spec=data) * u.Unit(y_unit)
                 new_spec = (spectral_axis_conversion(data.spectral_axis.value,