-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specutils 2 compatibility #2922
Draft
rosteen
wants to merge
8
commits into
spacetelescope:main
Choose a base branch
from
rosteen:specutils-2-compatibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Explanation of code and concepts
cubeviz
specviz
mosviz
testing
imviz
plugin
Label for plugins common to multiple configurations
specviz2d
labels
Jun 20, 2024
rosteen
force-pushed
the
specutils-2-compatibility
branch
5 times, most recently
from
January 6, 2025 17:55
787141a
to
f9d26cf
Compare
Fix coords mouseover when SkyCoord is before SpectralCoord More debugging Fix slice with different spectral_axis_index, add specutils_format kwarg to cubeviz parser Remove unused import Remove ESA parser from commissioning [skip ci] Generalizing coords_info to handle spectral axis first or last [ci skip] Working on debugging aperture photometry Need to pull meta from data not comp Fix aperture photometry and wrong coord order in coords_info Fix codestyle, delete defunct case in parser Change Spectrum1D to Spectrum Change class name in recent code additions Get spectral extraction working again for cylinder case Debugging wavelength dependent case Make sure spectral extraction result is linked when added to data collection Moved fix to correct place Fix indents Remove stray code from rebase Update missed Spectrum1D Debugging cubeviz parser First start on fixing testt Fix bad rebase in spectral extraction Starting to work through test failures Working through test failures Debugging spectral extraction
Finish fixing codestyle, probably still need functional fixes
rosteen
force-pushed
the
specutils-2-compatibility
branch
from
January 21, 2025 15:13
5024bfd
to
8ea20d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2762 after a significant rebase, with a better title and branch name that are more accurate to the scope of the PR. Still in draft, need to update tests