expose surface brightness units in internal get_display_units method

[kecnry]

Description

This pull request exposes surface brightness units (in addition to flux units) in app._get_display_units. This also adds support for requesting app._get_display_units('spectral_y') which will return either flux or SB, depending on which is being use on the y-axis of the spectral viewer. This is intended for internal use only, but could be useful for WIPs developing support in plugins to react to a change in display units.

cubeviz.app._get_display_unit('flux')
cubeviz.app._get_display_unit('sb')
cubeviz.app._get_display_unit('spectral')
cubeviz.app._get_display_unit('spectral_y')

Previously flux, sb, and spectral were supported as long as the plugin existed. This PR adds a fallback in the case where the plugin does not exist and also adds support for spectral_y to read from the flux_or_sb switch and then retrieve the appropriate unit.

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[haticekaratay]

Thanks for enabling the selection of parameters in the method. Are failing tests related to this PR?

[kecnry]

Are failing tests related to this PR?

Yep, I just also replied in #3107 (comment) that the default casting is causing issues with tests, so I may split that part out to a follow-up effort so that it doesn't block the review of the rest of this.

[cshanahan1]

looks good to me. maybe a small test to make sure future changes don't break this since a lot of the plugins will be using this? i'll update this function when the non-steradian surface brightness unit support is finished.

[gibsongreen]

Outside of the python 3.11 failure everything looks good to me, love the convenience this adds. We might want to make a note that in generalizing the square angle that this will be an additional area to account for when we support more then sr.

[kecnry]

hmmm I thought this was passing tests before, but still doesn't on a rebase. I'll have to try to track down and fix before merging - if its anything major, I'll ask for re-reviews.

[kecnry]

passes now on a rebase without any changes 🤷‍♂️ so I'll merge!

[codecov]

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.85%. Comparing base (ac16e60) to head (9fb99d7).
Report is 136 commits behind head on main.

Files with missing lines	Patch %	Lines
jdaviz/app.py	68.75%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3112      +/-   ##
==========================================
- Coverage   88.85%   88.85%   -0.01%     
==========================================
  Files         112      112              
  Lines       17396    17409      +13     
==========================================
+ Hits        15458    15468      +10     
- Misses       1938     1941       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.