Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-menu: exclude subset on orientation layer in visibility logic #3373

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 30, 2024

Description

This pull request ensures that spatial subsets when linked by WCS do not show a mixed visibility state due to the (non-visible) subset state attached to the WCS-only orientation layer. This was simpler to implement than only considering the top layer, and should effectively yield the same results unless the user manually modifies subset visibility state at a per-layer level.

This is to address #3220 (comment)

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry modified the milestones: 4.2, 4.1.1 Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (a8b3e03) to head (02a8f2b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3373   +/-   ##
=======================================
  Coverage   88.13%   88.14%           
=======================================
  Files         127      127           
  Lines       19695    19698    +3     
=======================================
+ Hits        17359    17362    +3     
  Misses       2336     2336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review December 30, 2024 20:45
@pllim pllim added the backport-v4.1.x on-merge: backport to v4.1.x label Dec 30, 2024
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@kecnry kecnry merged commit 3cb9540 into spacetelescope:main Jan 2, 2025
33 checks passed
@kecnry kecnry deleted the dm-subset-vis branch January 2, 2025 16:38
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jan 2, 2025
kecnry added a commit that referenced this pull request Jan 2, 2025
rosteen pushed a commit to rosteen/jdaviz that referenced this pull request Jan 6, 2025
…pacetelescope#3373)

* stylized label: exclude subset on wcs-only layer
* fallback when zorder is None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants