-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-menu: exclude subset on orientation layer in visibility logic #3373
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 88.13% 88.14%
=======================================
Files 127 127
Lines 19695 19698 +3
=======================================
+ Hits 17359 17362 +3
Misses 2336 2336 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
…tion layer in visibility logic
…visibility logic (#3378) Co-authored-by: Kyle Conroy <[email protected]>
…pacetelescope#3373) * stylized label: exclude subset on wcs-only layer * fallback when zorder is None
Description
This pull request ensures that spatial subsets when linked by WCS do not show a mixed visibility state due to the (non-visible) subset state attached to the WCS-only orientation layer. This was simpler to implement than only considering the top layer, and should effectively yield the same results unless the user manually modifies subset visibility state at a per-layer level.
This is to address #3220 (comment)
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.