Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orientation: remove deprecated link_type, wcs_use_affine #3385

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 9, 2025

Description

This pull request removes link_type and wcs_use_affine from the user APIs in the orientation plugin (Imviz) for the 4.2 release (deprecated since 4.0).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.2 milestone Jan 9, 2025
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Jan 9, 2025
@kecnry kecnry force-pushed the orientation-remove-deprecated branch from 46489a0 to 446ae82 Compare January 9, 2025 17:48
@kecnry kecnry mentioned this pull request Jan 9, 2025
9 tasks
@kecnry kecnry force-pushed the orientation-remove-deprecated branch from 446ae82 to 24c51ab Compare January 9, 2025 17:54
@kecnry kecnry marked this pull request as ready for review January 9, 2025 18:03
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should double check that removed API is no longer called in our notebooks here and also downstream.

Thanks!

CHANGES.rst Outdated Show resolved Hide resolved
@pllim
Copy link
Contributor

pllim commented Jan 9, 2025

Should https://jdaviz.readthedocs.io/en/latest/imviz/plugins.html#id2 be updated as well?

@kecnry kecnry force-pushed the orientation-remove-deprecated branch from 24c51ab to 424cfbe Compare January 9, 2025 19:40
@kecnry
Copy link
Member Author

kecnry commented Jan 9, 2025

Did a find and replace across all notebooks in the repo - I think downstream notebooks are up to them to update as they update the jdaviz requirement 🤷‍♂️

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (e8510da) to head (424cfbe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3385      +/-   ##
==========================================
- Coverage   88.03%   88.03%   -0.01%     
==========================================
  Files         127      127              
  Lines       19739    19722      -17     
==========================================
- Hits        17378    17363      -15     
+ Misses       2361     2359       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kecnry kecnry merged commit ae2aae8 into spacetelescope:main Jan 10, 2025
21 checks passed
@kecnry kecnry deleted the orientation-remove-deprecated branch January 10, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants