-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orientation: remove deprecated link_type, wcs_use_affine #3385
orientation: remove deprecated link_type, wcs_use_affine #3385
Conversation
46489a0
to
446ae82
Compare
446ae82
to
24c51ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should double check that removed API is no longer called in our notebooks here and also downstream.
Thanks!
Should https://jdaviz.readthedocs.io/en/latest/imviz/plugins.html#id2 be updated as well? |
24c51ab
to
424cfbe
Compare
Did a find and replace across all notebooks in the repo - I think downstream notebooks are up to them to update as they update the jdaviz requirement 🤷♂️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3385 +/- ##
==========================================
- Coverage 88.03% 88.03% -0.01%
==========================================
Files 127 127
Lines 19739 19722 -17
==========================================
- Hits 17378 17363 -15
+ Misses 2361 2359 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This pull request removes
link_type
andwcs_use_affine
from the user APIs in the orientation plugin (Imviz) for the 4.2 release (deprecated since 4.0).Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.