-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refresh button which updates sound device list #3387
Add refresh button which updates sound device list #3387
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 127 127
Lines 19735 19747 +12
=======================================
+ Hits 17370 17381 +11
- Misses 2365 2366 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to modify the UI in the future (put the button with an icon more associated with the dropdown and show a spinner, etc), but since this may only be temporary, I think its reasonable to leave simple for now. Thanks!
(I think this can probably count as trivial and only needs one approval - but does need a changelog before merge)
@@ -17,6 +17,8 @@ New Features | |||
Cubeviz | |||
^^^^^^^ | |||
|
|||
- Enhancements for the cube sonification plugin. [#3387] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you expecting to combine this with other PRs? Should we add more details or is this intentionally vague?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'm expecting to combine it with the change message in #3377
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, feel free to merge then and do so!
Description
This pull request adds a Refresh button which reruns
sounddevices.query_devices()
and updates the output device dropdown.Fixes #3334
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Enhancements for the cube sonification plugin. [#3387]
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.