Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh button which updates sound device list #3387

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

javerbukh
Copy link
Contributor

@javerbukh javerbukh commented Jan 10, 2025

Description

This pull request adds a Refresh button which reruns sounddevices.query_devices() and updates the output device dropdown.

Fixes #3334

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Enhancements for the cube sonification plugin. [#3387]

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Jan 10, 2025
@javerbukh javerbukh added this to the 4.2 milestone Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (d019ae4) to head (9106c93).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...configs/cubeviz/plugins/sonify_data/sonify_data.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3387   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files         127      127           
  Lines       19735    19747   +12     
=======================================
+ Hits        17370    17381   +11     
- Misses       2365     2366    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to modify the UI in the future (put the button with an icon more associated with the dropdown and show a spinner, etc), but since this may only be temporary, I think its reasonable to leave simple for now. Thanks!

(I think this can probably count as trivial and only needs one approval - but does need a changelog before merge)

@javerbukh javerbukh added the trivial Only needs one approval instead of two label Jan 13, 2025
@@ -17,6 +17,8 @@ New Features
Cubeviz
^^^^^^^

- Enhancements for the cube sonification plugin. [#3387]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you expecting to combine this with other PRs? Should we add more details or is this intentionally vague?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'm expecting to combine it with the change message in #3377

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, feel free to merge then and do so!

@javerbukh javerbukh merged commit 2084d96 into spacetelescope:main Jan 13, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure sounddevices list is up-to-date
2 participants