-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace logging with warnings #3396
Conversation
d425c46
to
c75a78f
Compare
devdeps failures are unrelated |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the cleanup!
(is any of this worth backporting?) |
Re: backport -- You didn't deprecate any plugin thingy in v4.1.x, did you? Even if you did, I don't think the stuff is showing up in the notebook anyway because your API refactor stuff isn't backported, right? So, no, I don't think this needs backporting. |
Gah looks like I have to rebase after #3400 is merged. |
Also update tests and sort some imports. Replaced a couple of accidental deprecated usage internally. Handle those warnings everywhere else.
c75a78f
to
ab5f6b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 128 128
Lines 19844 19844
=======================================
Hits 17388 17388
Misses 2456 2456 ☔ View full report in Codecov by Sentry. |
Description
In trying to figure out why deprecating warning is thrown when I do
specviz = Specviz()
, I found out that it is fromlogging
. The use oflogging
in Jdaviz does not quite make sense because we do not have a custom logger to begin with. Looks like all we use logging for is to emit deprecation warning and unit warning. I think this is better done by just usingwarnings
directly, which we then can control directly either from Python proper or pytest.While I am at it, also did some
isort
because I cannot help myself.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.