flux_conversion and indirect_conversion tests to use flux_conversion_general #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conversion_general, fix broken cases, move to new file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the flux conversion refactoring effort to move towards consolidating all flux conversion code in one place.
Currently, spectral axis translations are handled by utils.flux_conversion or utils.indirect_conversion, and in an effort to replace calls to these with calls to core.flux_conversion_general (an existing function that handles all other flux unit conversions in the app), the tests need to be updated. This PR replaces tests that called utils.flux_conversion or utils.indirect_conversion with flux_conversion_general. The results are the same, with the exception tests that call 'indirect_conversion', which were previously returning incorrect results and have updated.
I removed a few tests that test translation when the length of the array is 2, which is interpreted as y limit min and max. I am going to move the logic for this outside of flux_conversion_general so it is not ambiguous, and these test cases will be re-added with that PR (so this PR can be considered a draft until then)